Repository navigation
fix(bigtable): respect query limit smaller than pageSize and avoid mutating Query in QueryPaginator - #14821
Merged
Conversation
…tating Query in QueryPaginator
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the QueryPaginator constructor in Query.java to clone the query object and properly adjust its limit, preventing unintended mutations to the original query. It also adds corresponding unit tests in QueryTest.java to verify that the original query remains unchanged and to test scenarios where the limit is smaller than the chunk size. The feedback suggests simplifying the conditional logic in the constructor using a ternary operator to reduce code duplication and improve readability.
igorbernstein2
enabled auto-merge (squash)
October 28, 2026 20:38
mutianf
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues in
Query.QueryPaginator:Math.min(pageSize, remainingRows)when the query has an overall row limit smaller thanpageSize(matchingQueryPaginator#advance).QuerysocreatePaginatorandadvancedo not mutate the caller'sQueryinstance in-place.The primary issue is that when the paginated query has a limit smaller than the configured page size of the paginator, the query limit incorrectly gets expanded to the page size